Fix sqlite warnings #101
Merged
Fix sqlite warnings #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Update the compiler flags from `-analyzer-disable-checker -Xanalyzer deadcode` to `-analyzer-disable-all-checks`
Move sqlite amalgamation to a subspec in order to add compiler flags to its files and stop showing warnings
heitortsergent
force-pushed
the
fix_sqlite_warnings
branch
from
811023d to
0528003
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #78.
Move sqlite amalgamation files to a subspec inside the
KeenClient.podspecfile, so we can apply compiler flags to it and suppress the warnings. That way they won't show up when the SDK is being used as part of other projects.You can test the PR by using a Podfile in a project like this:
Then building the project and checking that the Issue navigator doesn't throw any errors.