Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlite3 amalgamation version #78

Open
ksylvest opened this issue Mar 18, 2015 · 3 comments
Open

Update sqlite3 amalgamation version #78

ksylvest opened this issue Mar 18, 2015 · 3 comments
Labels
Milestone

Comments

@ksylvest
Copy link

Running on XCode 6.2 the library currently has 30 warnings in keen_io_sqlite3.c.

@heitortsergent
Copy link
Contributor

Hey @ksylvest, I'm looking into this. Just ran the static analyzer and it gave me 24 issues:

Would you mind double-checking that Xcode gave out 30 warnings? I don't wanna miss any of them. :)

@ksylvest
Copy link
Author

I've since upgrade to XCode 6.3 and it shows 32 issues:

screen shot 2015-04-19 at 8 51 43 pm
screen shot 2015-04-19 at 8 51 47 pm

Thanks!

@heitortsergent
Copy link
Contributor

@ksylvest I dug into this a little further and the keen_io_sqlite3 is just the amalgamation of the regular sqlite3 library, so the errors should be nothing more than false positives.

That said, the version we have in the library is outdated, so I'm gonna change the issue title to update the current version of the sqlite3 library

@heitortsergent heitortsergent changed the title Fix Value Conversion Warnings and Ambiguous Expression Warnings Update sqlite3 amalgamation version May 17, 2015
@baumatron baumatron added this to the 4.0.0 milestone Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants