Merge pull request #299 from rounak/har-crash-fix

Fix crash when exporting HAR file
kean · Oct 4, 2024 · efac97a · efac97a
2 parents 2a0d1f5 + 3dd1cbd
commit efac97a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/Sources/Pulse/LoggerStore/LoggerStore.swift b/Sources/Pulse/LoggerStore/LoggerStore.swift
@@ -766,9 +766,10 @@ extension LoggerStore {
     /// - parameter predicate: By default, `nil`.
     public func messages(
         sortDescriptors: [SortDescriptor<LoggerMessageEntity>] = [SortDescriptor(\.createdAt, order: .forward)],
-        predicate: NSPredicate? = nil
+        predicate: NSPredicate? = nil,
+        context: NSManagedObjectContext? = nil
     ) throws -> [LoggerMessageEntity] {
-        try viewContext.fetch(LoggerMessageEntity.self) {
+        try (context ?? viewContext).fetch(LoggerMessageEntity.self) {
             $0.sortDescriptors = sortDescriptors.map(NSSortDescriptor.init)
             $0.predicate = predicate
         }
@@ -781,9 +782,10 @@ extension LoggerStore {
     /// - parameter predicate: By default, `nil`.
     public func tasks(
         sortDescriptors: [SortDescriptor<NetworkTaskEntity>] = [SortDescriptor(\.createdAt, order: .forward)],
-        predicate: NSPredicate? = nil
+        predicate: NSPredicate? = nil,
+        context: NSManagedObjectContext? = nil
     ) throws -> [NetworkTaskEntity] {
-        try viewContext.fetch(NetworkTaskEntity.self) {
+        try (context ?? viewContext).fetch(NetworkTaskEntity.self) {
             $0.sortDescriptors = sortDescriptors.map(NSSortDescriptor.init)
             $0.predicate = predicate
         }

diff --git a/Sources/PulseUI/Helpers/HARDocument.swift b/Sources/PulseUI/Helpers/HARDocument.swift
@@ -18,7 +18,7 @@ struct HARDocument: Encodable {
     init(store: LoggerStore) throws {
         var entries: [Entry] = []
         var pages: [Page] = []
-        try Dictionary(grouping: store.tasks(), by: \.url).values.forEach { networkTasks in
+        try Dictionary(grouping: store.tasks(context: store.backgroundContext), by: \.url).values.forEach { networkTasks in
             let pageId = "page_\(pages.count)"
             pages.append(
                 .init(
@@ -29,7 +29,7 @@ struct HARDocument: Encodable {
             )
             entries.append(contentsOf: networkTasks.map { .init(entity: $0, pageId: pageId) })
         }
-        try store.messages().forEach { message in
+        try store.messages(context: store.backgroundContext).forEach { message in
             if let task = message.task {
                 entries.append(.init(entity: task, pageId: "page_\(pages.count)"))
             }