Fixed incorrect code generated with 'additionalProperties:true'

kdurnoga · Aug 13, 2018 · b5756a6 · b5756a6
1 parent 3e0253d
commit b5756a6
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/modules/vertx-swagger-codegen/src/main/resources/javaVertXServer/MainApiVerticle.mustache b/modules/vertx-swagger-codegen/src/main/resources/javaVertXServer/MainApiVerticle.mustache
@@ -25,7 +25,7 @@ public class MainApiVerticle extends AbstractVerticle {
 
     @Override
     public void start(Future<Void> startFuture) throws Exception {
-    	LOGGER.info("Starting MainApiVerticle");
+    	LOGGER.info("Starting MainApiVerticle...");
         Json.mapper.registerModule(new JavaTimeModule());
     	FileSystem vertxFileSystem = vertx.fileSystem();
         vertxFileSystem.readFile("swagger.json", readFile -> {

diff --git a/modules/vertx-swagger-codegen/src/main/resources/javaVertXServer/pojo.mustache b/modules/vertx-swagger-codegen/src/main/resources/javaVertXServer/pojo.mustache
@@ -1,22 +1,21 @@
 @JsonInclude(JsonInclude.Include.NON_NULL) 
-public class {{classname}} {{#parent}}extends {{{parent}}}{{/parent}} {{#serializableModel}}implements Serializable{{/serializableModel}} {
+public class {{classname}}{{#parent}} extends {{{parent}}}{{/parent}}{{#serializableModel}} implements Serializable{{/serializableModel}} {
   {{#vars}}{{#isEnum}}
 
 {{>enumClass}}{{/isEnum}}{{#items.isEnum}}{{#items}}
-
 {{>enumClass}}{{/items}}{{/items.isEnum}}
   private {{{datatypeWithEnum}}} {{name}} = {{{defaultValue}}};{{/vars}}
 
   public {{classname}} () {
 
   }
-
+  {{#vars}}{{#-first}}
   public {{classname}} ({{#vars}}{{{datatypeWithEnum}}} {{name}}{{#hasMore}}, {{/hasMore}}{{/vars}}) {
     {{#vars}}
     this.{{name}} = {{name}};
     {{/vars}}
   }
-
+  {{/-first}}{{/vars}}
   {{#vars}}
     {{#vendorExtensions.extraAnnotation}}{{vendorExtensions.extraAnnotation}}{{/vendorExtensions.extraAnnotation}}
   @JsonProperty("{{baseName}}")
@@ -28,6 +27,17 @@ public class {{classname}} {{#parent}}extends {{{parent}}}{{/parent}} {{#seriali
     return this;
   }
 
+  {{#isMapContainer}}
+  public {{classname}} put{{nameInCamelCase}}Item(String key, {{{items.datatypeWithEnum}}} {{name}}Item) {
+    {{^required}}
+    if (this.{{name}} == null) {
+      this.{{name}} = {{{defaultValue}}};
+    }
+    {{/required}}
+    this.{{name}}.put(key, {{name}}Item);
+    return this;
+  }
+  {{/isMapContainer}}
   {{/vars}}
 
   @Override

diff --git a/...tx-swagger-router/src/main/java/com/github/phiz71/vertx/swagger/router/SwaggerRouter.java b/...tx-swagger-router/src/main/java/com/github/phiz71/vertx/swagger/router/SwaggerRouter.java
@@ -202,8 +202,10 @@ private static void configureRoute(Route route, String serviceId, Operation oper
 						}
 					} catch (Throwable t) {
 						vertxLogger.error("Internal Server Error", t);
-						response.setStatusCode(HttpResponseStatus.INTERNAL_SERVER_ERROR.code());
-						response.end();
+						if (!response.ended()) {
+							response.setStatusCode(HttpResponseStatus.INTERNAL_SERVER_ERROR.code());
+							response.end();
+						}
 					}
 				});
 			} catch (Exception e) {