btrfs-progs: doc: add a note on qgroup limit with inconsitent flag #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like all qgroup functions, if qgroup is marked inconsistent, limit will not work as expected. In fact with recent kernels, limit and qgroup number updating will be fully skipped if qgroup is already inconsistent. Add one extra note on `btrfs qgroup limit` subcommand for it. Reported-by: Vojtech Lacina <[email protected]> Link: https://bugzilla.suse.com/show_bug.cgi?id=1235765 Signed-off-by: Qu Wenruo <[email protected]>
kdave
approved these changes
Jan 28, 2025
| @@ -31,6 +31,11 @@ ownership. For example a fresh snapshot shares almost all the blocks with the | |||
| original subvolume, new writes to either subvolume will raise towards the | |||
| exclusive limit. | |||
|
|
|||
| .. note:: | |||
| Qgroup limit only works when qgroup is in a consistent status. | |||
There was a problem hiding this comment.
"Qgroup limit works only when a qgroup is in a consistent state."
| @@ -31,6 +31,11 @@ ownership. For example a fresh snapshot shares almost all the blocks with the | |||
| original subvolume, new writes to either subvolume will raise towards the | |||
| exclusive limit. | |||
|
|
|||
| .. note:: | |||
| Qgroup limit only works when qgroup is in a consistent status. | |||
| If by some workload, qgroup is mark inconsistent, the limit will no longer | |||
There was a problem hiding this comment.
"If some workload marks qgroup as inconsistent (for example <WHAT... >) the limits will not apply until the inconsistent flag is cleared but :command:btrfs quota rescan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like all qgroup functions, if qgroup is marked inconsistent, limit will not work as expected.
In fact with recent kernels, limit and qgroup number updating will be fully skipped if qgroup is already inconsistent.
Add one extra note on
btrfs qgroup limitsubcommand for it.Reported-by: Vojtech Lacina [email protected]
Link: https://bugzilla.suse.com/show_bug.cgi?id=1235765