Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #92 #93

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix #92 #93

merged 1 commit into from
Dec 30, 2024

Conversation

dockfries
Copy link

@dockfries dockfries commented Dec 28, 2024

let's go!

@dockfries dockfries marked this pull request as ready for review December 28, 2024 14:10
@katursis
Copy link
Owner

Thank you for your contribution.

  1. I'm concerned about old commits being present. Let's fix it so this PR only contains your changes.
  2. Have you personally tested that the emulation works as expected with your changes?
  3. I think the proposed changes should not affect PR_EmulateIncomingRPC, because BitStream RPC doesn't have a packetid at the beginning.
  4. The bs->resetReadPointer() call can be removed if bs->SetReadOffset(8) is added.

@dockfries
Copy link
Author

dockfries commented Dec 29, 2024

  1. I will reset the commit and recommit it.
  2. I tested in my environment (samp-node) only packet, it works, and I believe that's the issue.
  3. for rpc, i'm wrong, yes , no SetReadOffset is needed.
  4. ok, removed resetReadPointer()

I couldn't find the source code about onReceivePacket (only network.hpp), and refer to legacy_network_impl.cpp
I just saw that open.mp calls SetReadOffset(8).

@katursis katursis merged commit 1ea35b7 into katursis:omp Dec 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants