fastq2comp: clippy fixes

fastq2comp/src/extract_comp.rs

@@ -435,6 +435,7 @@ pub struct Output {
 }
 
 /// Takes in reader (for FASTQ lines) and SampleArgs, returns [`BaseComp`]
+/// Expects file to be non-empty.
 pub fn run<T>(fastq_reader: FASTQReader<T>) -> BaseComp
 where
     T: BufRead,

fastq2comp/src/lib.rs

@@ -122,6 +122,21 @@ impl BaseCompCol {
             N: apply(self.N),
         }
     }
+
+    pub fn extract(&mut self, s: &u8) {
+        match s {
+            b'A' => self.A += 1,
+            b'T' => self.T += 1,
+            b'G' => self.G += 1,
+            b'C' => self.C += 1,
+            b'N' => self.N += 1,
+            _ => panic!(
+                "Invalid character {:?} == {:?} found in read",
+                *s as char,
+                s.to_ascii_lowercase()
+            ),
+        }
+    }
 }
 
 impl Default for BaseCompCol {
@@ -257,20 +272,3 @@ mod col_base_comp_tests {
         assert_eq!(read.N, 20, "Testing N");
     }
 }
-
-impl BaseCompCol {
-    pub fn extract(&mut self, s: &u8) {
-        match s {
-            b'A' => self.A += 1,
-            b'T' => self.T += 1,
-            b'G' => self.G += 1,
-            b'C' => self.C += 1,
-            b'N' => self.N += 1,
-            _ => panic!(
-                "Invalid character {:?} == {:?} found in read",
-                *s as char,
-                s.to_ascii_lowercase()
-            ),
-        }
-    }
-}

server/src/tempdir.rs

@@ -1,7 +1,7 @@
 use log::{debug, log_enabled, trace};
 use std::ops::Deref;
 use std::{
-    path::{Path, PathBuf},
+    path::PathBuf,
     process::Command,
 };
 
@@ -33,16 +33,6 @@ impl TempDir {
             cleanup: true,
         }
     }
-
-    /// Create a new TempDir from an existing path.
-    /// Will not delete the directory on drop.
-    pub fn from_dir(path: &Path) -> Self {
-        let path = path.to_path_buf();
-        Self {
-            path,
-            cleanup: false,
-        }
-    }
 }
 
 impl Deref for TempDir {