Add KUBEXIT_EXIT_CODE_OVERRIDE parameter #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have closed and reopened PR to re-trigger lint status check, but it failed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have tried to use kubexit for sidecar container to be terminated once main container finished when our cronjob pods where running.
But our side container exit with non 0 exit code when it received SIGTERM which kubexit sends. So we decided to add parameter to override exit code that kubexit exits with as it may be useful not only for us but for other use cases too.
Please let me know if I should update README.md or modify e2e-tests to use this flag too.