Make the time spend waiting for things to settle down configurable #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this change as I've faced similar issues with the hook. |
|
This repo is no longer actively maintained. https://github.com/SeattleDevs/letsencrypt-cloudflare-hook is the maintained forked. I have cherry picked your commit and added it to that repo. Feel free to open future PRs in that repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some trouble while requesting my first wildcard certificate, because Let's Encrypt checked the challenge to quickly. I thought making it the time spend waiting for things to settle down configurable was the most sensible option to avoid these problems in the future. I currently use 30s.