Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make health use getters and setters #520

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix: make health use getters and setters #520

wants to merge 2 commits into from

Conversation

dragoncoder047
Copy link
Contributor

use modern getters and setters for hp and maxHP

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 18, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@520

commit: a240001

@niceEli
Copy link
Member

niceEli commented Nov 27, 2024

This could be breaking though?

@dragoncoder047
Copy link
Contributor Author

That's why it's probably v4000 only

@lajbel
Copy link
Collaborator

lajbel commented Nov 27, 2024

I have to think this more

@lajbel lajbel marked this pull request as draft November 28, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niceEli niceEli niceEli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragoncoder047 @niceEli @lajbel