Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ add golang ci lint and fix lint errors #56

Merged
merged 5 commits into from
Apr 21, 2021

Conversation

ludusrusso
Copy link
Collaborator

@ludusrusso ludusrusso commented Apr 18, 2021

What this PR does / why we need it:

Add golang CI linting

Which issue(s) this PR fixes
Related to #52
Closes #51

@ludusrusso ludusrusso changed the title 🛠️ add golang ci lint 🛠️ add golang ci lint and fix lint errors Apr 18, 2021
Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes...
Additionally I think it can be useful to add the golangci config file.

.github/workflows/golang.yaml Outdated Show resolved Hide resolved
.github/workflows/golang.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@davideimola davideimola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludusrusso ludusrusso merged commit c298278 into kannon-email:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return error missing
2 participants