fix(SUP-44377): Embeds impact on page load #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbalvasserman
requested review from
MosheMaorKaltura,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
SivanA-Kaltura
requested changes
Nov 3, 2024
SivanA-Kaltura
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
when there are lots of audio embeds sometimes there are several embed that stack on loading state.
current:
when the embeds not finished to load the listeners are happening after the event CHANGE_SOURCE_ENDED has thrown.
solution:
change the location of the listeners so they will run sooner and so when the event is thrown the listeners already called.
solved SUP-44377