Skip to content

Commit

Permalink
fix(SUP-44085): Two different players on the same page (#32)
Browse files Browse the repository at this point in the history
Description of the Changes
add the audio preset into audioPlayer object, part of - kaltura/kaltura-player-js#842
  • Loading branch information
Tzipi-kaltura authored Sep 4, 2024
1 parent 57d243e commit d2e45b8
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 29 deletions.
61 changes: 33 additions & 28 deletions cypress/e2e/audio-player.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -235,41 +235,46 @@ describe('audio player plugin', () => {
});

it('should not loop playback when not clicked', () => {
cy.get('[data-testid="audio-player-loop-button"] button').should('be.visible');
player?.play();
setTimeout(() => {
cy.get('[data-testid="audio-player-loop-button"] button').should('be.visible');
player?.play();

return cy.wrap(
new Promise(resolve => {
let playCount = 0;
player?.addEventListener('play', () => {
++playCount;
});
return cy.wrap(
new Promise(resolve => {
let playCount = 0;
player?.addEventListener('play', () => {
++playCount;
});

setTimeout(() => {
if (playCount === 1) {
resolve(true);
}
}, 6000);
})
);
setTimeout(() => {
if (playCount === 1) {
resolve(true);
}
}, 6000);
})
);
}, 3000);
});

it('should loop playback when clicked', () => {
cy.get('[data-testid="audio-player-loop-button"] button').should('be.visible').click({force: true});
player?.play();
setTimeout(() => {
cy.get('[data-testid="audio-player-loop-button"] button').should('be.visible').click({force: true});
player?.play();

return cy.wrap(
new Promise(resolve => {
let playCount = 0;
player?.addEventListener('play', () => {
++playCount;
return cy.wrap(
new Promise(resolve => {
let playCount = 0;
player?.addEventListener('play', () => {
++playCount;

if (playCount >= 2) {
resolve(true);
}
});
})
);
}, 3000);

if (playCount >= 2) {
resolve(true);
}
});
})
);
});
});
});
Expand Down
5 changes: 4 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,7 @@ const AudioPreset = {
};

// the preset needs to be injected into the player config before the player ui is loaded
window.kalturaCustomPreset = [AudioPreset];
if (!window.kalturaCustomPreset) {
window.kalturaCustomPreset = {};
}
window.kalturaCustomPreset['audioPlayer'] = [AudioPreset];

0 comments on commit d2e45b8

Please sign in to comment.