-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RAG API Server to use Async/Await #835
Open
ishaansehgal99
wants to merge
9
commits into
main
Choose a base branch
from
Ishaan/sync-async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+187
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaansehgal99
requested review from
Fei-Guo,
helayoty and
zhuangqh
as code owners
January 22, 2025 22:05
ishaansehgal99
had a problem deploying
to
unit-tests
January 22, 2025 22:05 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 22, 2025 22:05 — with
GitHub Actions
Failure
ishaansehgal99
had a problem deploying
to
e2e-test
January 22, 2025 22:05 — with
GitHub Actions
Error
please take a look |
ishaansehgal99
had a problem deploying
to
unit-tests
January 23, 2025 00:30 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 23, 2025 00:30 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 23, 2025 00:30 — with
GitHub Actions
Error
Fei-Guo
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async def health_check():
As we discussed, should we remove async here?
Fei-Guo
reviewed
Jan 23, 2025
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:07 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:07 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 24, 2025 04:07 — with
GitHub Actions
Error
…haan/sync-async
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:07 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:07 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 24, 2025 04:07 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:08 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:08 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 24, 2025 04:08 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:10 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 24, 2025 04:10 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 24, 2025 04:10 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 25, 2025 05:20 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
unit-tests
January 25, 2025 05:20 — with
GitHub Actions
Error
ishaansehgal99
had a problem deploying
to
e2e-test
January 25, 2025 05:20 — with
GitHub Actions
Error
ishaansehgal99
requested a deployment
to
unit-tests
January 26, 2025 06:59 — with
GitHub Actions
Waiting
ishaansehgal99
requested a deployment
to
unit-tests
January 26, 2025 06:59 — with
GitHub Actions
Waiting
ishaansehgal99
requested a deployment
to
e2e-test
January 26, 2025 06:59 — with
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Endpoints are currently sequentially blocking synchronous. After review we use async-await pattern correctly.
PR also fixes up the endpoints to be more REST-friendly - here's the three new/fixed endpoints
@app.get("/indexes", response_model=List[str]) - returns all indexes names (new endpoint)
...
@app.get("/indexes/{index_name}/documents", response_model=ListDocumentsResponse) - returns all documents in an index (new endpoint)
....
@app.get("/documents", response_model=ListDocumentsResponse) - returns all documents across all indexes