Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Reorg e2e test code to be reused in RAG e2e tests #834

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore: Reorg e2e test code to be reused in RAG e2e tests #834

merged 1 commit into from
Jan 24, 2025
+244 −198

Conversation

bangqipropel
Copy link
Collaborator

@bangqipropel bangqipropel commented Jan 22, 2025 •
edited
Loading

Reason for Change:
add an e2e base setup file for the duplicate part

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel changed the title Chore: Reorg e2e test code to be reused in RAG e2e tests chore: Reorg e2e test code to be reused in RAG e2e tests Jan 22, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 43 files with indirect coverage changes

e2e test reorg to reuse
d236789 
Signed-off-by: Bangqi Zhu <[email protected]>
@Fei-Guo Fei-Guo merged commit c96fb2d into main Jan 24, 2025
5 of 7 checks passed
@Fei-Guo Fei-Guo deleted the e2e_reorg branch January 24, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

@zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bangqipropel @Fei-Guo