Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RAG server changes for consistency #813

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: RAG server changes for consistency #813

wants to merge 2 commits into from
+81 −15

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:

  1. Add query model ID step from inference deployment
  2. Add Error detection if no model ID is needed
  3. Changed the parameters design for the previous two changes

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@bangqipropel bangqipropel changed the title RAG server patch for consistency feat: RAG server patch for consistency Jan 10, 2025
@bangqipropel bangqipropel changed the title feat: RAG server patch for consistency feat: RAG server changes for consistency Jan 10, 2025
@bangqipropel bangqipropel force-pushed the RAG_server_patch branch 2 times, most recently from ff107dc to b4e328d Compare January 10, 2025 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@ishaansehgal99 ishaansehgal99 Awaiting requested review from ishaansehgal99 ishaansehgal99 is a code owner

@zhuangqh zhuangqh Awaiting requested review from zhuangqh zhuangqh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bangqipropel