Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [SKU modularization] AWS chart changes #710

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

smritidahal653
Copy link
Contributor

Reason for Change:

Updating kaito charts for aws integration:

  • add clusterrole permission for ec2nodeclasses resource
  • add new env variable in deployment CLUSTER_NAME as this environment is needed to create EC2 Node Class
  • update nodeSelectorTerm for nvidia-device-plugin daemonset based on the cloud provider
  • add AWS specific nodeSelectorRequirement for nodeClaim obj
  • add InstanceStorePolicyRAID0 to EC2 node class to share node's ephermeral storage among pods that request it. Additional information here
  • fixing a bug on nodeClaim create (kubeClient.Create) - if the nodeClaim fails to get created, we retry to create it again. However, on kubeClient.Create, certain metadata are set like resourceVersion which will be passed along in the retires if we don't pass the DeepCopy(). This metadata being populated will throw an error from KubeClient resourceVersion should not be set on objects to be created

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@zhuangqh zhuangqh merged commit f7e6d66 into kaito-project:main Nov 27, 2024
6 checks passed
@smritidahal653 smritidahal653 deleted the sdahal/aws_chart_change branch January 6, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants