Kvm support when opt-level > 1 #606

junsooo · 2022-02-25T06:28:21Z

Related context:
#604
#605

Gabriel4256 · 2022-02-25T06:45:59Z

kernel-rs/src/arch/arm/start.rs

@@ -40,7 +40,10 @@ pub static mut stack0: Stack = Stack::new();
 pub unsafe fn start() {
    // launch other cores
    if cpu_id() == 0 {
-        let kernel_entry = unsafe { _entry.as_mut_ptr() as usize } as u64;
+        // XXX(https://github.com/kaist-cp/rv6/issues/605): rustc bug?


rv6/kernel-rs/src/trap.rs

Line 200 in 10ab52b

// TODO(https://github.com/kaist-cp/rv6/issues/517): safety?

주석 형식을 이 부분처럼 TODO로 해주실 수 있을까요? (XXX -> TODO). rv6에서 원래 사용하던 형식이라 일관성을 유지하는 것이 좋아보입니다.

3474b86 여기서 todo로 수정 완료했습니다!

fix bench.py to process when test length == 1

3445bc2

junsooo marked this pull request as ready for review February 25, 2022 06:35

Gabriel4256 reviewed Feb 25, 2022

View reviewed changes

junsooo added 2 commits February 25, 2022 16:00

TODO: support kvm enable when opt-level > 1

3474b86

fix smc_call func to return x0, x1, x2, x3

eafc542

jeehoonkang merged commit 66badc7 into kaist-cp:main Feb 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kvm support when opt-level > 1 #606

Kvm support when opt-level > 1 #606

junsooo commented Feb 25, 2022

Gabriel4256 Feb 25, 2022

junsooo Feb 25, 2022 •

edited

Loading

Kvm support when opt-level > 1 #606

Kvm support when opt-level > 1 #606

Conversation

junsooo commented Feb 25, 2022

Gabriel4256 Feb 25, 2022

Choose a reason for hiding this comment

junsooo Feb 25, 2022 • edited Loading

Choose a reason for hiding this comment

junsooo Feb 25, 2022 •

edited

Loading