Fix saving and restoring of 3D map view settings #219
Conversation
| map->setSelectionColor( mMapCanvas->selectionColor() ); | ||
| map->setBackgroundColor( mMapCanvas->canvasColor() ); | ||
| #endif | ||
| map->setOutputDpi( QGuiApplication::primaryScreen()->logicalDotsPerInch() ); |
There was a problem hiding this comment.
is this the right place for this?
what happens with a secondary screen?
There was a problem hiding this comment.
I think this is based on simplified assumptions (straight 1:1 copy from the QGIS source) that the 3D is shown on the same screen as the main application window.
I can adapt, but I think to be really meaningful, this would also need to react when the widget is dragged to another screen which afaik is one of the tricky things to do with Qt. So maybe we can assume that people who work with multiple screens have identical ones?
There was a problem hiding this comment.
yep, I've always had troubles with QGIS on multiple screens.
Fine with me like this, we can wait for any bugreport and properly fix this upstream.
kadas/app/3d/kadas3dintegration.cpp
Outdated
| connect( QgsProject::instance(), &QgsProject::readProject, [this] { | ||
| if ( m3DMapCanvasWidget ) | ||
| { | ||
| QDomElement viewConfig = QgsProject::instance()->viewsManager()->get3DViewSettings( "kadas-3d" ); |
There was a problem hiding this comment.
should we use static string for this identifier?
No description provided.