Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix different instances of KadasMapCanvasItemManager python/c++ #210

Closed
wants to merge 1 commit into from
Closed

Fix different instances of KadasMapCanvasItemManager python/c++ #210

wants to merge 1 commit into from

Conversation

domi4484
Copy link
Contributor

@domi4484 domi4484 commented Jan 13, 2025 •
edited
Loading

For some reason the instance of KadasMapCanvasItemManager that should be a singleton was different between C++ and python

@domi4484 domi4484 requested a review from 3nids January 14, 2025 07:20
@3nids 3nids requested a review from m-kuhn January 15, 2025 06:27
@3nids
Copy link
Contributor

3nids commented Jan 15, 2025

@m-kuhn any idea why this was the case? Is this malformed here

kadas-albireo2/kadas/gui/kadasmapcanvasitemmanager.cpp

Line 31 in 576d589

static KadasMapCanvasItemManager manager;
?

@domi4484
Copy link
Contributor Author

@m-kuhn ping

@m-kuhn
Copy link
Collaborator

m-kuhn commented Jan 17, 2025

it could be the same as in #107

solution: we should use Q_GLOBA_STATIC instead

@domi4484
Copy link
Contributor Author

Superseded by #218

@domi4484 domi4484 closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3nids 3nids Awaiting requested review from 3nids

@m-kuhn m-kuhn Awaiting requested review from m-kuhn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domi4484 @3nids @m-kuhn