Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query #22

Merged
merged 6 commits into from
Jan 19, 2025
Merged

query #22

merged 6 commits into from
Jan 19, 2025

Conversation

kaakaa
Copy link
Owner

@kaakaa kaakaa commented Jan 19, 2025

  • chore: remove unused code
  • refactor: create DataQuery component
  • feat: enable to toggle sql editor
  • feat: add pop up to explain data schema and add some refactors
  • refactor: add getBaseUrl func

@kaakaa kaakaa requested a review from Copilot January 19, 2025 03:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • webapp/src/components/statistics/PullRequestsCount.tsx: Evaluated as low risk
  • webapp/src/components/Summary.tsx: Evaluated as low risk
  • webapp/src/components/statistics/ReposCount.tsx: Evaluated as low risk
  • webapp/src/components/Statistics.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

webapp/src/components/data/data_query.tsx:46

  • The useEffect hook should have 'inputQuery' as a dependency to ensure it only runs when 'inputQuery' changes. Change to: useEffect(() => { onQuerySubmit(inputQuery); }, [inputQuery]);
useEffect(() => { onQuerySubmit(inputQuery); }, []);
@kaakaa kaakaa merged commit 9c63dae into main Jan 19, 2025
@kaakaa kaakaa deleted the query branch January 19, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant