Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spa gh pages #18

Merged
merged 3 commits into from
Jan 6, 2025
Merged

spa gh pages #18

merged 3 commits into from
Jan 6, 2025

Conversation

kaakaa
Copy link
Owner

@kaakaa kaakaa commented Jan 6, 2025

  • fix: add a workaround for spa on gh-pages
  • feat: show message when load data was failed

@kaakaa kaakaa requested a review from Copilot January 6, 2025 13:31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • webapp/index.html: Language not supported
  • webapp/public/404.html: Language not supported
Comments suppressed due to low confidence (3)

webapp/src/components/PullRequests.tsx:130

  • [nitpick] The error message 'Failed to load remote parquet' might not be clear to all users. Consider rephrasing it to something more user-friendly, such as 'Failed to load data: ${loadError}'.
<p>{`Failed to load remote parquet: ${loadError}`}</p>

webapp/src/components/PullRequests.tsx:94

  • Ensure that 'e' is always an object with a 'message' property to avoid potential issues. Consider adding a check or default value.
setLoadError(e?.message);

webapp/src/components/PullRequests.tsx:128

  • Ensure that the new error handling behavior is covered by tests to verify that the error message is displayed correctly.
if (loadError) {
@kaakaa kaakaa merged commit 77769b8 into main Jan 6, 2025
@kaakaa kaakaa deleted the spa-gh-pages branch January 6, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant