Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary #12

Merged
merged 3 commits into from
Jan 5, 2025
Merged

summary #12

merged 3 commits into from
Jan 5, 2025

Conversation

kaakaa
Copy link
Owner

@kaakaa kaakaa commented Jan 5, 2025

  • feat: add onClick event to summary charts
  • fix: fix header style

@kaakaa kaakaa requested a review from Copilot January 5, 2025 13:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@kaakaa kaakaa requested a review from Copilot January 5, 2025 13:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

webapp/src/components/PullRequests.tsx:28

  • Changing the query parameter from = to like might introduce a bug if the intention was to match the exact date. Please verify if this change is intended.
if (params.get('createdAt')) q.push(`createdAt like '${params.get('createdAt')}%'`);

webapp/src/components/statistics/ReposCount.tsx:9

  • The variable name 'basepath' should be renamed to 'basePath' to follow JavaScript naming conventions.
const basepath = import.meta.env.BASE_URL
@kaakaa kaakaa merged commit 747a37b into main Jan 5, 2025
@kaakaa kaakaa deleted the summary branch January 5, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant