Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge japanese-to-english multilingual branch #1860

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Merge japanese-to-english multilingual branch #1860

wants to merge 30 commits into from

Conversation

baileyeet
Copy link

No description provided.

root and others added 22 commits August 1, 2024 15:08
@baileyeet baileyeet changed the title Merge multilingual branch Merge japanese-to-english multilingual branch Jan 7, 2025
@baileyeet baileyeet marked this pull request as draft January 7, 2025 05:41
csukuangfj
csukuangfj reviewed Jan 8, 2025
View reviewed changes
egs/reazonspeech/ASR/RESULTS.md

```shell
./zipformer/streaming_decode.py \
--epoch 28 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Reazonspeech is a large dataset, I suggest that you replace --epoch with --iter. See also RESULTS.md from our Gigaspeech recipe. You can find example usages of --iter there.

@baileyeet
Copy link
Author

With regards to Setup Python 3.10.15 issue - how do I resolve this issue? I didn't change anything related to Python issue.

@csukuangfj
Copy link
Collaborator

With regards to Setup Python 3.10.15 issue - how do I resolve this issue? I didn't change anything related to Python issue.

please change

icefall/.github/workflows/style_check.yml

Line 39 in ab91112

python-version: [3.10.15]

to

 python-version: [3.10]

That is, change 3.10.15 to 3.10.

It is an issue of GitHub actions and is not related to your PR.

@baileyeet
Copy link
Author

With regards to Setup Python 3.10.15 issue - how do I resolve this issue? I didn't change anything related to Python issue.

please change

icefall/.github/workflows/style_check.yml

Line 39 in ab91112

python-version: [3.10.15]

to

 python-version: [3.10]

That is, change 3.10.15 to 3.10.

It is an issue of GitHub actions and is not related to your PR.

Looks like this hasn't resolved the issue.

@csukuangfj
Copy link
Collaborator

Please use

"3.10"

not

3.10

@baileyeet baileyeet marked this pull request as ready for review January 14, 2025 22:41
@csukuangfj
Copy link
Collaborator

@JinZr Can you have a review?

@JinZr
Copy link
Collaborator

JinZr commented Jan 21, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csukuangfj csukuangfj csukuangfj left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baileyeet @csukuangfj @JinZr