Merge pull request sxs-collaboration#6462 from wthrowe/clang-tidy-lib…

…sharp
jyoo1042 · Jan 29, 2025 · 35f8569 · 35f8569
2 parents 51dbb85 + e39f436
commit 35f8569
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/.clang-tidy b/.clang-tidy
@@ -59,6 +59,8 @@ Checks: '*,
 -misc-confusable-identifiers,
 # thinks constexpr variables in header files cause ODR violations,
 -misc-definitions-in-headers,
+# Insufficiently configurable, does not handle system headers well,
+-misc-include-cleaner,
 # false positives,
 -misc-noexcept-move-constructor,
 -misc-non-private-member-variables-in-classes,

diff --git a/.github/workflows/Tests.yaml b/.github/workflows/Tests.yaml
@@ -269,7 +269,7 @@ jobs:
           -D BUILD_PYTHON_BINDINGS=ON
           $GITHUB_WORKSPACE
 
-          make -j4 module_All
+          make -j4 module_All Libsharp-external
       - name: Check clang-tidy
         run: >
           UPSTREAM_HASH=$(git merge-base HEAD upstream/develop)

diff --git a/cmake/SetupClangTidy.cmake b/cmake/SetupClangTidy.cmake
@@ -25,6 +25,7 @@ if (CLANG_TIDY_BIN)
   message(STATUS "clang-tidy: ${CLANG_TIDY_BIN}")
   set(MODULES_TO_DEPEND_ON
     module_All
+    Libsharp
     )
   if (TARGET SpectrePch)
     list(APPEND MODULES_TO_DEPEND_ON SpectrePch)