Final pass before 5.0 release #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Invalidates On Focus Loss`, - `Hover works in foreign code (javascript)` - `Mid Token Completions Do Not Overwrite`
If it helps, it might be indicative of performance problem
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes In R Magics- there was a problem with cell being out of view in a long test notebookCompletes In Strings Or Python Dictionaries- fixed by adding 2 seconds delay, may require future investigationHover Triggers Automatically- fixed by increasing retrials of wiggling simulationUpdate hover after character deletion- fixed by increasing retrials of wiggling simulationInvalidates On Focus Loss- upstream issue https://github.com/jupyterlab/jupyterlab/issues/ 14496Dockerrename - upstream issue (https://github.com/jupyterlab/jupyterlab/issues/ 15104)Robotmode - upstream issue (https://github.com/MarketSquare/jupyterlab_robotmode/issues/ 14)Mid Token Completions Do Not Overwrite- looks like a bug in the upstream reconciliator, no upstream issue yet but it basically requires changes on JEP level to make kernels return proper ranges rather than randomly either return completion with or without suffixColumns Can Be Hidden- passes locally; also tested in Firefox and Chrome works okHover works in foreign code (javascript)- passes locally but flakyDiagnostics Panel Works After Removing Foreign Document- passes locallyPython Dottedthis highlights a genuine problem with dotted settings, now documented.Many of the tests will not be fixed before JupyterLab 4.1 gets released because of how unreliable is the workaround of getting the adapter.