Handle priority change #1110
Draft
Handle priority change #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Open
jtpio
force-pushed
the
handle-priority-change
branch
from
d163a21 to
71bec8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This was originally brought up in jupyterlab/jupyterlab#17147.
Opening this PR early to start exploring a way to handle dynamic updates when the priorities change, and implement the following TODO:
jupyterlab-lsp/packages/jupyterlab-lsp/src/index.ts
Line 178 in ec483e9
Code changes
On settings update, check if priorities changed and if so, reset the connection.
User-facing changes
Quickly testing locally, this seems to produce the desired effect (lsp section update updated in the panel, and different completions based on which server is active):
jupyterlab-lsp-reload-connection.webm
Backwards-incompatible changes
Chores