Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes): Add a missing %s for converting an argument passed to a logging statement (fixes #45). #44

Merged
merged 9 commits into from
Jan 8, 2025
Merged

fix(routes): Add a missing %s for converting an argument passed to a logging statement (fixes #45). #44

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
625f42f
Log exception with exc_info in custom Flask exception handler.
xx12345798 Jul 25, 2024
190dfe0
Log response in custom Flask after request handler
xx12345798 Sep 8, 2024
4f35129
addressed the comments of using response.get_data instead of response…
xx12345798 Sep 15, 2024
392a426
use jsonify to replace response dumped by json.dump
xx12345798 Sep 27, 2024
f937db9
Merge branch 'junhaoliao:main' into flask-logging
xx12345798 Sep 27, 2024
4efa440
remove the unused json import and revert the response of type applica…
xx12345798 Jan 5, 2025
abf9d30
fixed missing %s
xx12345798 Jan 5, 2025
2bcb814
merge
xx12345798 Jan 5, 2025
ada79e7
add missing %s into the log message of file application/routes/vnc.py…
xx12345798 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion application/routes/vnc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def change_vncpasswd():

vnc, reason = create_connection(session_id, ConnectionType.VNC)
if reason != '':
logger.error("create_connection() failed with status=", reason)
logger.error("create_connection() failed with status=%s", reason)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Use consistent terminology in log messages.

Great job adding the missing %s to properly include the reason in the log statement. However, consider updating the message text to also refer to "reason" rather than "status," ensuring clarity for future maintainers.

abort(403, description=reason)

passwd = request.json.get('passwd')
Expand Down
Loading