reject sqids with many numbers #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great find, thank you for this! Indeed for the primary key of an instance we never want more than one number returned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
django-sqidsreject sqid fields with more than one number in it.This actually happened to me in production. A random character sequence turned out to be a proper sqid, just with two numbers instead of one. (For example,
[1, 42]instead of just[1].)Because
django-sqidsonly looks at first number, an url with such sqid is actually valid, and in my case resolved to a page with real existing model instance.That url then got indexed by a popular search engine, which got confused because the canonical url wouldn't match, messing up the SEO stuff.