Skip to content

Commit

Permalink
Merge pull request ekumenlabs#33 from Intermodalics/update-urdfdom
Browse files Browse the repository at this point in the history
Update console_bridge, urdfdom_headers, urdfdom and collada_dom
  • Loading branch information
meyerj authored Nov 28, 2018
2 parents 208d4c7 + 9ad0283 commit 7c4cc91
Show file tree
Hide file tree
Showing 5 changed files with 81 additions and 24 deletions.
7 changes: 5 additions & 2 deletions do_everything.sh
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export RBA_TOOLCHAIN=$ANDROID_NDK/build/cmake/android.toolchain.cmake
[ -d $prefix/libs/urdfdom_headers ] || run_cmd get_library urdfdom_headers $prefix/libs
[ -d $prefix/libs/libiconv-1.14 ] || run_cmd get_library libiconv $prefix/libs
[ -d $prefix/libs/libxml2-2.9.1 ] || run_cmd get_library libxml2 $prefix/libs
[ -d $prefix/libs/collada-dom-2.4.0 ] || run_cmd get_library collada_dom $prefix/libs
[ -d $prefix/libs/collada_dom ] || run_cmd get_library collada_dom $prefix/libs
[ -d $prefix/libs/eigen-3.3.5 ] || run_cmd get_library eigen $prefix/libs
[ -d $prefix/libs/assimp-3.1.1 ] || run_cmd get_library assimp $prefix/libs
[ -d $prefix/libs/qhull-2015.2 ] || run_cmd get_library qhull $prefix/libs
Expand Down Expand Up @@ -162,6 +162,9 @@ if [[ $skip -ne 1 ]] ; then
# Patch assimp - Build as static lib
apply_patch $my_loc/patches/assimp.patch

# Patch console_bridge - Disable unit tests (unsatisfied dependencies)
apply_patch $my_loc/patches/console_bridge.patch

# Patch urdfdom - Build as static lib
apply_patch $my_loc/patches/urdfdom.patch

Expand Down Expand Up @@ -338,7 +341,7 @@ echo
[ -f $prefix/target/lib/liburdfdom_model.a ] || run_cmd build_library urdfdom $prefix/libs/urdfdom
[ -f $prefix/target/lib/libiconv.a ] || run_cmd build_library_with_toolchain libiconv $prefix/libs/libiconv-1.14
[ -f $prefix/target/lib/libxml2.a ] || run_cmd build_library_with_toolchain libxml2 $prefix/libs/libxml2-2.9.1
[ -f $prefix/target/lib/libcollada-dom2.4-dp.a ] || run_cmd build_library collada_dom $prefix/libs/collada-dom-2.4.0
[ -f $prefix/target/lib/libcollada-dom2.4-dp.a ] || run_cmd build_library collada_dom $prefix/libs/collada_dom
[ -f $prefix/target/lib/libassimp.a ] || run_cmd build_library assimp $prefix/libs/assimp-3.1.1
[ -f $prefix/target/lib/libeigen.a ] || run_cmd build_library eigen $prefix/libs/eigen-3.3.5
[ -f $prefix/target/lib/libqhullstatic.a ] || run_cmd build_library qhull $prefix/libs/qhull-2015.2
Expand Down
11 changes: 6 additions & 5 deletions get_library.sh
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,13 @@ elif [ $1 == 'bzip2' ]; then
URL=https://github.com/osrf/bzip2_cmake.git
COMP='git'
elif [ $1 == 'collada_dom' ]; then
URL=http://ufpr.dl.sourceforge.net/project/collada-dom/Collada%20DOM/Collada%20DOM%202.4/collada-dom-2.4.0.tgz
COMP='gz'
URL=https://github.com/rdiankov/collada-dom.git
COMP='git'
HASH='v2.4.4'
elif [ $1 == 'console_bridge' ]; then
URL=https://github.com/ros/console_bridge.git
COMP='git'
HASH='964a9a70e0fc607476e439b8947a36b07322c304'
HASH='0.3.2'
elif [ $1 == 'curl' ]; then
URL=http://curl.haxx.se/download/curl-7.39.0.tar.bz2
COMP='bz2'
Expand Down Expand Up @@ -83,11 +84,11 @@ elif [ $1 == 'tinyxml2' ]; then
elif [ $1 == 'urdfdom_headers' ]; then
URL=https://github.com/ros/urdfdom_headers.git
COMP='git'
HASH='9aed7256e06d62935966de2a9bc9ddfac96e7a85'
HASH='0.4.2'
elif [ $1 == 'urdfdom' ]; then
URL=https://github.com/ros/urdfdom.git
COMP='git'
HASH='c4ac03caf55369c64c61605b78f1b6071bb4acce'
HASH='0.4.2'
elif [ $1 == 'uuid' ]; then
URL=https://github.com/chadrockey/uuid_cmake
COMP='git'
Expand Down
12 changes: 6 additions & 6 deletions patches/collada_dom.patch
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
--- libs/collada-dom-2.4.0/CMakeLists.txt
+++ libs/collada-dom-2.4.0/CMakeLists.txt
--- libs/collada_dom/CMakeLists.txt
+++ libs/collada_dom/CMakeLists.txt
@@ -109,6 +109,8 @@ include(CheckCXXSourceCompiles)
include(CheckTypeSize)
find_package(PkgConfig)
Expand All @@ -10,8 +10,8 @@
add_definitions("-fno-strict-aliasing -Wall")
endif()

--- libs/collada-dom-2.4.0/dom/CMakeLists.txt
+++ libs/collada-dom-2.4.0/dom/CMakeLists.txt
--- libs/collada_dom/dom/CMakeLists.txt
+++ libs/collada_dom/dom/CMakeLists.txt
@@ -27,7 +27,7 @@ if( OPT_COLLADA14 )
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/1.4 DESTINATION ${COLLADA_DOM_INCLUDE_INSTALL_DIR} COMPONENT ${COMPONENT_PREFIX}-dev PATTERN ".svn" EXCLUDE PATTERN ".~" EXCLUDE)
endif()
Expand All @@ -22,8 +22,8 @@
set_target_properties(collada-dom PROPERTIES
COMPILE_FLAGS "${COLLADA_COMPILE_FLAGS}"

--- libs/collada-dom-2.4.0/dom/external-libs/pcre-8.02/pcrecpp.cc
+++ libs/collada-dom-2.4.0/dom/external-libs/pcre-8.02/pcrecpp.cc
--- libs/collada_dom/dom/external-libs/pcre-8.02/pcrecpp.cc
+++ libs/collada_dom/dom/external-libs/pcre-8.02/pcrecpp.cc
@@ -47,6 +47,7 @@
#include "pcrecpp.h"
#include "pcre_stringpiece.h"
Expand Down
12 changes: 12 additions & 0 deletions patches/console_bridge.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
--- libs/console_bridge/CMakeLists.txt
+++ libs/console_bridge/CMakeLists.txt
@@ -89,5 +89,7 @@ SET_DIRECTORY_PROPERTIES(PROPERTIES
ADDITIONAL_MAKE_CLEAN_FILES ${CMAKE_BINARY_DIR}/console_bridge-config.cmake
ADDITIONAL_MAKE_CLEAN_FILES ${CMAKE_BINARY_DIR}/console_bridge.pc)

-enable_testing()
-add_subdirectory(test)
+if(NOT ANDROID)
+ enable_testing()
+ add_subdirectory(test)
+endif()
63 changes: 52 additions & 11 deletions patches/urdfdom.patch
Original file line number Diff line number Diff line change
@@ -1,25 +1,66 @@
--- libs/urdfdom/urdf_parser/CMakeLists.txt 2014-11-13 18:42:30.721044671 -0300
+++ libs/urdfdom/urdf_parser/CMakeLists.txt 2014-11-13 18:38:03.475500828 -0300
@@ -1,18 +1,18 @@
--- libs/urdfdom/urdf_parser/CMakeLists.txt
+++ libs/urdfdom/urdf_parser/CMakeLists.txt
@@ -1,42 +1,46 @@
include_directories(include)

-add_library(urdfdom_world SHARED src/pose.cpp src/model.cpp src/link.cpp src/joint.cpp src/world.cpp)
+add_library(urdfdom_world src/pose.cpp src/model.cpp src/link.cpp src/joint.cpp src/world.cpp)
target_link_libraries(urdfdom_world ${tinyxml_libraries} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_world PROPERTIES SOVERSION 0.3)
target_link_libraries(urdfdom_world ${TinyXML_LIBRARIES} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_world PROPERTIES SOVERSION ${URDF_MAJOR_MINOR_VERSION})

-add_library(urdfdom_model SHARED src/pose.cpp src/model.cpp src/link.cpp src/joint.cpp)
+add_library(urdfdom_model src/pose.cpp src/model.cpp src/link.cpp src/joint.cpp)
target_link_libraries(urdfdom_model ${tinyxml_libraries} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_model PROPERTIES SOVERSION 0.3)
target_link_libraries(urdfdom_model ${TinyXML_LIBRARIES} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_model PROPERTIES SOVERSION ${URDF_MAJOR_MINOR_VERSION})

-add_library(urdfdom_sensor SHARED src/urdf_sensor.cpp)
+add_library(urdfdom_sensor src/urdf_sensor.cpp)
target_link_libraries(urdfdom_sensor urdfdom_model ${tinyxml_libraries} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_sensor PROPERTIES SOVERSION 0.3)
target_link_libraries(urdfdom_sensor urdfdom_model ${TinyXML_LIBRARIES} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_sensor PROPERTIES SOVERSION ${URDF_MAJOR_MINOR_VERSION})

-add_library(urdfdom_model_state SHARED src/urdf_model_state.cpp src/twist.cpp)
+add_library(urdfdom_model_state src/urdf_model_state.cpp src/twist.cpp)
target_link_libraries(urdfdom_model_state ${tinyxml_libraries} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_model_state PROPERTIES SOVERSION 0.3)
target_link_libraries(urdfdom_model_state ${TinyXML_LIBRARIES} ${console_bridge_LIBRARIES} ${Boost_LIBRARIES})
set_target_properties(urdfdom_model_state PROPERTIES SOVERSION ${URDF_MAJOR_MINOR_VERSION})

# --------------------------------

-add_executable(check_urdf src/check_urdf.cpp)
-target_link_libraries(check_urdf urdfdom_model urdfdom_world)
+if(NOT ANDROID)
+ add_executable(check_urdf src/check_urdf.cpp)
+ target_link_libraries(check_urdf urdfdom_model urdfdom_world)

-add_executable(urdf_to_graphiz src/urdf_to_graphiz.cpp)
-target_link_libraries(urdf_to_graphiz urdfdom_model)
+ add_executable(urdf_to_graphiz src/urdf_to_graphiz.cpp)
+ target_link_libraries(urdf_to_graphiz urdfdom_model)

-# urdf_mem_test is a binary for testing, not a unit test
-add_executable(urdf_mem_test test/memtest.cpp)
-target_link_libraries(urdf_mem_test urdfdom_model)
+ # urdf_mem_test is a binary for testing, not a unit test
+ add_executable(urdf_mem_test test/memtest.cpp)
+ target_link_libraries(urdf_mem_test urdfdom_model)

-# unit test to fix geometry problems
-add_executable(urdf_unit_test test/urdf_unit_test.cpp)
-target_link_libraries(urdf_unit_test urdfdom_model ${Boost_LIBRARIES})
-add_test(urdf_unit_test urdf_unit_test)
+ # unit test to fix geometry problems
+ add_executable(urdf_unit_test test/urdf_unit_test.cpp)
+ target_link_libraries(urdf_unit_test urdfdom_model ${Boost_LIBRARIES})
+ add_test(urdf_unit_test urdf_unit_test)
+endif()

INSTALL(TARGETS urdfdom_model DESTINATION ${CMAKE_INSTALL_LIBDIR})
INSTALL(TARGETS urdfdom_world DESTINATION ${CMAKE_INSTALL_LIBDIR})
-INSTALL(TARGETS check_urdf urdf_to_graphiz urdf_mem_test
- DESTINATION ${CMAKE_INSTALL_BINDIR})
+if(NOT ANDROID)
+ INSTALL(TARGETS check_urdf urdf_to_graphiz urdf_mem_test
+ DESTINATION ${CMAKE_INSTALL_BINDIR})
+endif()
INSTALL(TARGETS urdfdom_sensor DESTINATION ${CMAKE_INSTALL_LIBDIR})
INSTALL(TARGETS urdfdom_model_state DESTINATION ${CMAKE_INSTALL_LIBDIR})
INSTALL(DIRECTORY include/urdf_parser DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})

0 comments on commit 7c4cc91

Please sign in to comment.