Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for (nextDNS) node attributes (nodeattrs) #2329

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Support for (nextDNS) node attributes (nodeattrs) #2329

wants to merge 5 commits into from
+565 −16

Conversation

nielscil
Copy link

@nielscil nielscil commented Jan 6, 2025 •
edited
Loading

This PR adds support for node attributes and device specific nextDNS settings. It fixes #2319

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@kradalby
Copy link
Collaborator

kradalby commented Jan 7, 2025

Hi, the policy is being rewritten, so nothing will be accepted into it for the time being, see:
#2230 (comment)

very keen to get this in after, but might be a waste of effort and require quite a bit of rewriting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohdearaugustin ohdearaugustin Awaiting requested review from ohdearaugustin ohdearaugustin will be requested when the pull request is marked ready for review ohdearaugustin is a code owner

@nblock nblock Awaiting requested review from nblock nblock will be requested when the pull request is marked ready for review nblock is a code owner

@juanfont juanfont Awaiting requested review from juanfont juanfont will be requested when the pull request is marked ready for review juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby will be requested when the pull request is marked ready for review kradalby is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support for node attributes (nodeattrs)
2 participants
@nielscil @kradalby