set minimum hostname length of 2

Signed-off-by: Kristoffer Dalby <[email protected]>
juanfont · Jan 31, 2025 · 89323b5 · 89323b5
1 parent 5a8db83
commit 89323b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,8 @@
   [#2391](https://github.com/juanfont/headscale/pull/2391)
 - Do not allow renaming of users from OIDC
   [#2393](https://github.com/juanfont/headscale/pull/2393)
+- Change minimum hostname length to 2
+  [#2393](https://github.com/juanfont/headscale/pull/2393)
 
 ## 0.24.2 (2025-01-30)
 

diff --git a/hscontrol/util/dns.go b/hscontrol/util/dns.go
@@ -65,6 +65,11 @@ func ValidateUsername(username string) error {
 }
 
 func CheckForFQDNRules(name string) error {
+	// Ensure the username meets the minimum length requirement
+	if len(name) < 2 {
+		return errors.New("name must be at least 2 characters long")
+	}
+
 	if len(name) > LabelHostnameLength {
 		return fmt.Errorf(
 			"DNS segment must not be over 63 chars. %v doesn't comply with this rule: %w",