Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix failing tests #96

Merged
merged 1 commit into from
Jul 5, 2024
Merged

chore: fix failing tests #96

merged 1 commit into from
Jul 5, 2024

Conversation

marvinhagemeister
Copy link
Collaborator

@marvinhagemeister marvinhagemeister commented Jul 5, 2024

CI failures were caused by changes in corepack. It started printing additional logs to the terminal which we weren't expecting in our tests which then lead to the yarn berry check being incorrect. Luckily they are only printing on stderr so we just need to check for the version string on stdout.

Fixes #95

@marvinhagemeister marvinhagemeister marked this pull request as draft July 5, 2024 14:11
@marvinhagemeister marvinhagemeister merged commit 5212ce7 into main Jul 5, 2024
5 checks passed
@marvinhagemeister marvinhagemeister deleted the fix-tests branch July 5, 2024 15:15
Boshen referenced this pull request in oxc-project/monitor-oxc Jul 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsr](https://jsr.io)
([source](https://togithub.com/denoland/jsr-node-cli)) | [`^0.12.4` ->
`^0.13.0`](https://renovatebot.com/diffs/npm/jsr/0.12.4/0.13.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/jsr/0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/jsr/0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/jsr/0.12.4/0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/jsr/0.12.4/0.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>denoland/jsr-node-cli (jsr)</summary>

### [`v0.13.0`](https://togithub.com/jsr-io/jsr-npm/releases/tag/0.13.0)

[Compare
Source](https://togithub.com/denoland/jsr-node-cli/compare/0.12.4...0.13.0)

#### Features

- feat: Add `.npmrc` support check for newer Bun versions by
[@&#8203;ryoppippi](https://togithub.com/ryoppippi) in
[https://github.com/jsr-io/jsr-npm/pull/94](https://togithub.com/jsr-io/jsr-npm/pull/94)

#### Bug Fixes

- fix: allow scope to start with number by
[@&#8203;marvinhagemeister](https://togithub.com/marvinhagemeister) in
[https://github.com/jsr-io/jsr-npm/pull/87](https://togithub.com/jsr-io/jsr-npm/pull/87)

#### Maintenance

- chore: fix failing tests by
[@&#8203;marvinhagemeister](https://togithub.com/marvinhagemeister) in
[https://github.com/jsr-io/jsr-npm/pull/96](https://togithub.com/jsr-io/jsr-npm/pull/96)

#### New Contributors

- [@&#8203;ryoppippi](https://togithub.com/ryoppippi) made their first
contribution in
[https://github.com/jsr-io/jsr-npm/pull/94](https://togithub.com/jsr-io/jsr-npm/pull/94)

**Full Changelog**:
jsr-io/jsr-npm@0.12.4...0.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/oxc-project/monitor-oxc).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI is failing in main branch
2 participants