Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: .npmrc not written into workspace root #73

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

marvinhagemeister
Copy link
Collaborator

When a jsr command was invoked in a subfolder of a workspace root, we created the npmrc in the workspace member directory instead of the workspace parent folder. This PR fixes that.

Fixes #72

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 93b7cd4 into main Apr 15, 2024
5 checks passed
@marvinhagemeister marvinhagemeister deleted the npmrc-workspace branch April 15, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.npmrc needs to be craeted in the workspace root, not the current workspace
2 participants