fix: Build dist-esm before publishing release on npm
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marvinhagemeister
approved these changes
Mar 14, 2024
Open
EdJoPaTo
reviewed
Mar 17, 2024
Co-authored-by: EdJoPaTo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to use this module automatically. I have noticed that the
dist-esmfolder specified inpackage.jsondoes not exist. I looked at the GitHub Action workflow file and saw that onlynpm publishis called here. Within thepackage.json, however, onlytscis called in theprepublishOnlyscript, nottsc -p tsconfig.esm.json, which is responsible for the ESM build. I have adapted the line so thatnpm run buildis now executed (whch executes both builds).I hope that this fixes the problem in the next release and would of course be delighted if this happes soon. Thank you.