Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add publish command #14

Merged
merged 23 commits into from
Feb 27, 2024
Merged

feat: add publish command #14

merged 23 commits into from
Feb 27, 2024

Conversation

marvinhagemeister
Copy link
Collaborator

@marvinhagemeister marvinhagemeister commented Feb 23, 2024 •
edited
Loading

This PR adds a jsr publish command that calls deno publish under the hood.

@marvinhagemeister marvinhagemeister marked this pull request as ready for review February 27, 2024 09:06
lucacasonato
lucacasonato reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using a postinstall, can you do this only in the publish subcommand?

Otherwise users of jsr i have to download a 35 mb zip file for nothing.

scripts/postinstall.js Outdated Show resolved Hide resolved
@marvinhagemeister
Copy link
Collaborator Author

Good point, will do.

ry
ry approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucacasonato
lucacasonato approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, ty!

@marvinhagemeister marvinhagemeister merged commit 5ac4b23 into main Feb 27, 2024
3 checks passed
@marvinhagemeister marvinhagemeister deleted the publish-cmd branch February 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marvinhagemeister @ry @lucacasonato