perf: 定时任务全量加载速度优化 TencentBlueKing#3363

1.重构部分老代码，降低圈复杂度。
jsonwan · Jan 14, 2025 · 3849d51 · 3849d51
1 parent 5ad39d3
commit 3849d51
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/...ce-job-crontab/src/main/java/com/tencent/bk/job/crontab/service/impl/JobCronNameUtil.java b/...ce-job-crontab/src/main/java/com/tencent/bk/job/crontab/service/impl/JobCronNameUtil.java
@@ -32,32 +32,29 @@ public class JobCronNameUtil {
     /**
      * 获取Quartz Job名称
      *
-     * @param appId     Job业务ID
      * @param cronJobId 定时任务ID
      * @return Quartz Job名称
      */
-    public static String getJobName(long appId, long cronJobId) {
+    public static String getJobName(long cronJobId) {
         return "job_" + cronJobId;
     }
 
     /**
      * 获取Quartz Job分组
      *
-     * @param appId     Job业务ID
-     * @param cronJobId 定时任务ID
+     * @param appId Job业务ID
      * @return Quartz Job分组
      */
-    public static String getJobGroup(long appId, long cronJobId) {
+    public static String getJobGroup(long appId) {
         return "bk_app_" + appId;
     }
 
     /***
      * 获取通知Job名称
-     * @param appId Job业务ID
      * @param cronJobId 定时任务ID
      * @return 通知Job名称
      */
-    public static String getNotifyJobName(long appId, long cronJobId) {
-        return getJobName(appId, cronJobId) + "_notify";
+    public static String getNotifyJobName(long cronJobId) {
+        return getJobName(cronJobId) + "_notify";
     }
 }
diff --git a/...-job-crontab/src/main/java/com/tencent/bk/job/crontab/service/impl/QuartzServiceImpl.java b/...-job-crontab/src/main/java/com/tencent/bk/job/crontab/service/impl/QuartzServiceImpl.java
@@ -84,9 +84,9 @@ public boolean deleteJobFromQuartz(long appId, long cronJobId) {
         if (appId <= 0 || cronJobId <= 0) {
             return false;
         }
-        String jobName = JobCronNameUtil.getJobName(appId, cronJobId);
-        String jobGroup = JobCronNameUtil.getJobGroup(appId, cronJobId);
-        String notifyJobName = JobCronNameUtil.getNotifyJobName(appId, cronJobId);
+        String jobName = JobCronNameUtil.getJobName(cronJobId);
+        String jobGroup = JobCronNameUtil.getJobGroup(appId);
+        String notifyJobName = JobCronNameUtil.getNotifyJobName(cronJobId);
         try {
             quartzTaskHandler.deleteJob(JobKey.jobKey(jobName, jobGroup));
             quartzTaskHandler.deleteJob(JobKey.jobKey(notifyJobName, jobGroup));
@@ -106,8 +106,8 @@ public boolean deleteJobFromQuartz(long appId, long cronJobId) {
     private void addJobToQuartz(CronJobInfoDTO cronJobInfo) throws SchedulerException {
         Long appId = cronJobInfo.getAppId();
         Long cronJobId = cronJobInfo.getId();
-        String jobName = JobCronNameUtil.getJobName(appId, cronJobId);
-        String jobGroup = JobCronNameUtil.getJobGroup(appId, cronJobId);
+        String jobName = JobCronNameUtil.getJobName(cronJobId);
+        String jobGroup = JobCronNameUtil.getJobGroup(appId);
         QuartzTrigger trigger = buildTrigger(cronJobInfo);
 
         QuartzJob job = QuartzJobBuilder.newJob()
@@ -132,8 +132,8 @@ private void addJobToQuartz(CronJobInfoDTO cronJobInfo) throws SchedulerExceptio
      */
     private QuartzTrigger buildTrigger(CronJobInfoDTO cronJobInfo) {
         QuartzTrigger trigger = null;
-        String jobName = JobCronNameUtil.getJobName(cronJobInfo.getAppId(), cronJobInfo.getId());
-        String jobGroup = JobCronNameUtil.getJobGroup(cronJobInfo.getAppId(), cronJobInfo.getId());
+        String jobName = JobCronNameUtil.getJobName(cronJobInfo.getId());
+        String jobGroup = JobCronNameUtil.getJobGroup(cronJobInfo.getAppId());
         if (StringUtils.isNotBlank(cronJobInfo.getCronExpression())) {
             // 根据cron表达式执行的定时任务
             QuartzTriggerBuilder cronTriggerBuilder = QuartzTriggerBuilder.newTrigger()
@@ -171,8 +171,8 @@ private QuartzTrigger buildTrigger(CronJobInfoDTO cronJobInfo) {
     private void addNotifyJobIfNeed(CronJobInfoDTO cronJobInfo) throws SchedulerException {
         Long appId = cronJobInfo.getAppId();
         Long cronJobId = cronJobInfo.getId();
-        String notifyJobName = JobCronNameUtil.getNotifyJobName(appId, cronJobId);
-        String jobGroup = JobCronNameUtil.getJobGroup(appId, cronJobId);
+        String notifyJobName = JobCronNameUtil.getNotifyJobName(cronJobId);
+        String jobGroup = JobCronNameUtil.getJobGroup(appId);
         if (cronJobInfo.getNotifyOffset() > 0) {
             long notifyTime = 0L;
             if (StringUtils.isNotBlank(cronJobInfo.getCronExpression())) {