increase stall_velocity_threshold to pass grasp test #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you use the description in version after PR2/pr2_common#255 ? |
|
@k-okada FYI, many techniques (or hacks) were needed till PR2 successfully fetched cans from the fridge. |
|
@furushchev thank you for info |
k-okada
force-pushed
the
fix_kinetic_test
branch
2 times, most recently
from
598ff8b to
ee599e5
Compare
k-okada
force-pushed
the
fix_kinetic_test
branch
from
ee599e5 to
1a9422b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pr2_gazebo for kinetic was released early 2018, travis failed in kinetic test (https://travis-ci.org/jsk-ros-pkg/jsk_pr2eus/builds/361065737, #337)
It seems
start-graspnever returns because of weak effort? or never detected stall situation.This might be not a good solution, we need to more better simualtion of gripper. For example we set 5000 effort for simulation, but real robot uses ~25.