Enable json5 and json-stringify parsers by default (#92) #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two parsers were accidentally omitted from the default list. In particular, this broke the choice of parser for package.json files. So add them to the default list. This solves the original motivating factor for jscheid#92, but not jscheid#92 itself which is a request for enhanced debugging capabilities.
|
Thanks @aspiers. See if you can figure out the failing test, otherwise I'll try and have a look soon. |
|
I can't immediately, and weirdly I get a different failure when running the tests locally! |
|
See #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two parsers were accidentally omitted from the default list. In particular, this broke the choice of parser for
package.jsonfiles. So add them to the default list.This solves the original motivating factor for #92, but not #92 itself which is a request for enhanced debugging capabilities.