Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solution for module 3 task 1 #5

Merged
merged 2 commits into from
Dec 19, 2024
Merged

solution for module 3 task 1 #5

merged 2 commits into from
Dec 19, 2024

Conversation

skkonstantin
Copy link
Contributor

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 18, 2024

Добавляю преподавателя (@tadjik1) для код-ревью.

@jsru-1 jsru-1 requested a review from tadjik1 December 18, 2024 11:24
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 18, 2024

Решение было обновлено, посмотрим что скажет @tadjik1

tadjik1
tadjik1 approved these changes Dec 19, 2024
View reviewed changes
Copy link

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

отличное решение! хорошее разделение smsgateway и sender-email, в больших проектах это могут быть отдельные большие модули (с функциями ретрая, аналитикой и т.д.) 👍

@jsru-1 jsru-1 merged commit 5a5f24f into js-tasks-ru:master Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadjik1 tadjik1 tadjik1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skkonstantin @jsru-1 @tadjik1