Use cmake policy instead of minimum #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policy correctly scopes the changes to the Config file, rather than applying the change to the rest of the user's code when called from inside `find_package` or `find_dependency`.
jrmadsen
reviewed
Jan 22, 2025
| message(FATAL_ERROR "CMake >= 3.0.0 required") | ||
| endif() | ||
| cmake_policy(PUSH) | ||
| cmake_policy(VERSION 3.0.0...3.27) |
There was a problem hiding this comment.
Suggested change
| cmake_policy(VERSION 3.0.0...3.27) | |
| cmake_policy(VERSION 3.8.0...3.27) |
| @@ -1,10 +1,18 @@ | |||
| # -------------------------------------------------------------------------------------- # | |||
|
|
|||
| if("${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}" LESS 2.8) | |||
| if("${CMAKE_MAJOR_VERSION}.${CMAKE_MINOR_VERSION}" LESS 2.8) | ||
| message(FATAL_ERROR "CMake >= 3.0.0 required") | ||
| endif() | ||
| if(CMAKE_VERSION VERSION_LESS "3.0.0") |
There was a problem hiding this comment.
Why is this 3.0.0 and not 3.8.0?
There was a problem hiding this comment.
The updated usage mirrors the CMake-generated Targets.cmake file: assertions to check for the rough CMake version, then a scoped policy change for the file itself.
I suspect cmake does this for better backward compatibility with old versions: each successive test requires newer features. If you look at the cmake-generated Targets from any installation you'll see the same assertions in the same order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #51 and is related to some nasty obscure side effects of the policy alteration by the previous implementation, seen in celeritas-project/celeritas#1573.
It's unusual to use
cmake_minimum_requiredin a package config file, since it can alter policy scope elsewhere (depending, of course, on the policy that's been set). Thecmake_policycommand correctly scopes the changes to the Config file, rather than applying the change to the rest of the user's code when called from insidefind_packageorfind_dependency.The updated usage mirrors the CMake-generated
Targets.cmakefile: assertions to check for the rough CMake version, then a scoped policy change for the file itself.