Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mc_rtc_gui] change the robot type to handle more informations of mc_rbdyn::Robot #425

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

antodld
Copy link
Contributor

@antodld antodld commented Jan 18, 2024

This PR aims to provide more information of the mc_rbdyn::Robot through the mc_rtc::gui.
To do so, the PR adds a RobotMsg type handling all the info to be transmitted.

This will allow in the future to add more information about the mc_rbdyn::Robot through the mc_rtc::gui without the need to patch all gui clients repo.

However this update implies that all gui client using the robot module must be patched to handle the RobotMsg

@antodld
Copy link
Contributor Author

antodld commented Jan 24, 2024

The mc_rtc::gui::Robot type has been reverted to its original implementation and a new type mc_rtc::gui::RobotMsg has been added to handle more complex robot messages. The mc_rtc gui clients do not need to be updated directly anymore

@gergondet
Copy link
Member

Thanks @antodld

I have rebased the commit on the master branch and I have made the following changes (I have kept everything in a single commit so this commit could be referenced in the future as a way to introduce a new element into the GUI)

  • Append RobotMsg at the end of the Elements enum, this ensures that the type id does not change for the other elements (e.g. when updating mc_rtc on a robot but not on the terminal where the GUI is visualized)
  • Moved RobotMsg to the mc_rtc::gui namespace as RobotMsgData
  • Store a RobotMsg instance in the GUI object, otherwise rbd::paramToVector allocates on every call of the message building

@gergondet gergondet merged commit 585c5db into jrl-umi3218:master Jan 30, 2024
20 checks passed
@gergondet gergondet deleted the topic/guiRobotMsg branch January 30, 2024 07:10
gergondet added a commit that referenced this pull request Feb 5, 2024
Added
--

- [mc_rbdyn/GUI] Add helpers to visualize surfaces and convexes (#431)
- [mc_rtc/GUI] Added RobotMsg: a complete view of the robot state (#425)
- [mc_rtc] Add path helpers (#431)
- [utils/RobotVisualizer] Add a new tool to visualize a robot built on mc_rtc GUI (#431)

Changes
--

- [mc_rtc/GUI] Send scale vector for visual mesh instead of scalar (#430)

Fixes
--

- [mc_rbdyn] Always use default_attitude to initialize the attitude (#424)
- [mc_tasks] Clarify usage of targetSurface/targetFrame in ImpedanceTask
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants