Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary PR to evaluate GitHub workflow output #48

Closed
wants to merge 4 commits into from

Conversation

jppelteret
Copy link
Owner

No description provided.

@jppelteret jppelteret force-pushed the github_workflow_tmp branch 2 times, most recently from 0b4719d to 5f4b69c Compare April 14, 2022 06:52
@jppelteret
Copy link
Owner Author

jppelteret commented Apr 17, 2022

@Rombur FYI. I put together this branch to evaluate and fix the CI test failures. I took an educated guess as to how to fix some of the remaining issues, but it seems that those changes have not been 100% effective. There are still 4 failing tests after my last commit

	 96 - weak_forms/step-44-variant_02-residual_view_ad_02b.debug (Failed)
	141 - weak_forms/step-72-variant_01b_vec.debug (Failed)
	142 - weak_forms/step-72-variant_01c.debug (Failed)
	168 - weak_forms/step-transient_curl_curl-variant_02b.mpirun=3.debug (Failed)

Since I cannot reproduce these on my Mac, I've built a docker image on a Windows machine and am busy running all of the tests through that. Hopefully that will allow me to debug the at least 3 of the 4 failures. The step-72 tests are giving a floating point exception (not treated by the changes I made to the division binary operator), so I need to debug those using GDB. Even though I changed the evaluation point for the step-transient_curl_curl test, one still fails for some reason. Maybe I'll just extract some alternative output, as I need to refactor the test anyway (the mesh needs to change, amongst other things). I fear that the step-44-variant_02-residual_view_ad_02b test might not be treatable on the CI unless we build ADOL-C ourselves. I guess that the ubuntu package does not have the necessary build flags set (specifically the --enable-traceless-refcounting flag), but I do still need to double check this.

@jppelteret jppelteret force-pushed the github_workflow_tmp branch 2 times, most recently from bc13987 to 3f55814 Compare April 18, 2022 17:33
@jppelteret jppelteret force-pushed the github_workflow_tmp branch from 3f55814 to 52b6c46 Compare April 18, 2022 21:06
@jppelteret jppelteret added ready to test A flag that the CI runners should be ready to test the branch and removed ready to test A flag that the CI runners should be ready to test the branch labels Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch from 52b6c46 to a25f37a Compare April 18, 2022 21:10
@jppelteret jppelteret added ready to test A flag that the CI runners should be ready to test the branch and removed ready to test A flag that the CI runners should be ready to test the branch labels Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch from 45738ca to 5eb9642 Compare April 18, 2022 21:17
@jppelteret jppelteret added the ready to test A flag that the CI runners should be ready to test the branch label Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch 2 times, most recently from 96112d9 to be6a53c Compare April 18, 2022 21:21
@jppelteret jppelteret added ready to test A flag that the CI runners should be ready to test the branch and removed ready to test A flag that the CI runners should be ready to test the branch labels Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch 7 times, most recently from bf9a493 to 481fb12 Compare April 18, 2022 21:50
@jppelteret jppelteret removed the ready to test A flag that the CI runners should be ready to test the branch label Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch from 481fb12 to 1d8bf51 Compare April 18, 2022 21:59
@jppelteret jppelteret added the ready to test A flag that the CI runners should be ready to test the branch label Apr 18, 2022
@jppelteret jppelteret force-pushed the github_workflow_tmp branch from 1d8bf51 to 450de6b Compare April 18, 2022 22:06
@jppelteret
Copy link
Owner Author

Superseded by #43 in conjunction with #50 and #58

@jppelteret jppelteret closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to test A flag that the CI runners should be ready to test the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants