Win32: Add Rumble Support #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zer0xFF
force-pushed
the
rumble
branch
3 times, most recently
from
de6e4ab to
3ba4ae0
Compare
…amepad, since the current use case is vibration support
Zer0xFF
force-pushed
the
rumble
branch
2 times, most recently
from
2f7c52e to
69959d6
Compare
jpd002
reviewed
Nov 3, 2023
Source/input/PH_GenericInput.cpp
Outdated
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| void CPH_GenericInput::Update(uint8* ram) | |||
| { | |||
| for(auto* listener : m_listeners) | |||
| std::map<unsigned int, std::pair<uint8, uint8>> vibrationMap; | |||
There was a problem hiding this comment.
std::map is probably a bit overkill for this. We should use std::array<std::pair<uint8, uint8>, MAX_PADS>.
There was a problem hiding this comment.
updated, I've also added code to choose max value, just incase we implement vibration, in the other interfaces
… max value for motors
Fixes one crash that can occur when quitting the app.
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requries: jpd002/Play--Framework#41
Add basic Rumble/Vibration Support.
Just to note,
this will allow all platforms to compile, until we add support for the reset (there is also some derviative class that wont support those calls, aka QtProvider (aka keyboard) will never need to implement them)
CMotorBindingisn't a deriviate ofCBinding(as the name might suggest)