Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
OnInput
from a functional pointer to signal, for our use case, signals are better, since they're mutex protected (thread safe), thus reduce race chance, they simplify the code (no (explicit) guarding required), and allows multiple targets to request input.In Framework, we also added a new call
CSignal<>::ConnectOverride(...)
, which can be used to temporarly redirect events (e.g when configuring gamepads).Requires: jpd002/Play--Framework#40 (would need to rebase once that is merged)
Notes: tested on Windows only (changes are simple that if it compiles, we should be fine)