Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on input #1314

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Update on input #1314

merged 2 commits into from
Oct 26, 2023

Conversation

Zer0xFF
Copy link
Contributor

@Zer0xFF Zer0xFF commented Oct 26, 2023

Change OnInput from a functional pointer to signal, for our use case, signals are better, since they're mutex protected (thread safe), thus reduce race chance, they simplify the code (no (explicit) guarding required), and allows multiple targets to request input.

In Framework, we also added a new call CSignal<>::ConnectOverride(...), which can be used to temporarly redirect events (e.g when configuring gamepads).

Requires: jpd002/Play--Framework#40 (would need to rebase once that is merged)

Notes: tested on Windows only (changes are simple that if it compiles, we should be fine)

@jpd002 jpd002 changed the title Update on iput Update on input Oct 26, 2023
@jpd002 jpd002 merged commit 8b33edb into jpd002:master Oct 26, 2023
13 checks passed
@jpd002
Copy link
Owner

jpd002 commented Oct 26, 2023

Thanks for this!

@Zer0xFF Zer0xFF deleted the updateOnIput branch October 26, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants