fix: login flow without login_challenge

josxha · Dec 29, 2023 · ecfef45 · ecfef45
1 parent de1a812
commit ecfef45
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/KratosSelfService/Controllers/LoginController.cs b/KratosSelfService/Controllers/LoginController.cs
@@ -93,14 +93,16 @@ public async Task<IActionResult> Login(
     private string GetInitFlowUrl(string? aal, string? refresh, string? returnTo, string? organization,
         string? loginChallenge)
     {
-        return api.GetUrlForBrowserFlow("login", new Dictionary<string, string?>
+        var query = new Dictionary<string, string?>
         {
             ["aal"] = aal ?? "",
             ["refresh"] = refresh ?? "",
             ["return_to"] = returnTo ?? "",
-            ["organization"] = organization ?? "",
-            ["login_challenge"] = loginChallenge ?? ""
-        });
+            ["organization"] = organization ?? ""
+        };
+        if (!string.IsNullOrWhiteSpace(loginChallenge)) query["login_challenge"] = loginChallenge;
+
+        return api.GetUrlForBrowserFlow("login", query);
     }
 
     private async Task<IActionResult> RedirectToVerificationFlow(KratosLoginFlow flow)