Skip to content

Commit

Permalink
use login_challenge query param in login endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
josxha committed Dec 28, 2023
1 parent 97f5347 commit cf1d298
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions KratosSelfService/Controllers/LoginController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,15 @@ public async Task<IActionResult> Login(
[FromQuery] string? organization,
[FromQuery(Name = "login_challenge")] string? loginChallenge)
{
// oauth2 login challenge
if (!string.IsNullOrWhiteSpace(loginChallenge))
logger.LogDebug($"login_challenge found in URL query: {loginChallenge}");

if (flowId == null)
{
logger.LogDebug("No flow ID found in URL query initializing login flow");
// initiate flow
return Redirect(GetInitFlowUrl(aal, refresh, returnTo, organization));
return Redirect(GetInitFlowUrl(aal, refresh, returnTo, organization, loginChallenge));
}

KratosLoginFlow flow;
Expand All @@ -37,7 +41,7 @@ public async Task<IActionResult> Login(
{
logger.LogError("Error while getting the login flow, starting new flow. {Message}", exception.Message);
// restart flow
return Redirect(GetInitFlowUrl(aal, refresh, returnTo, organization));
return Redirect(GetInitFlowUrl(aal, refresh, returnTo, organization, loginChallenge));
}

if (flow.Ui.Messages?.Any(text => text.Id == 4000010) ?? false)
Expand Down Expand Up @@ -86,14 +90,16 @@ public async Task<IActionResult> Login(
}
}

private string GetInitFlowUrl(string? aal, string? refresh, string? returnTo, string? organization)
private string GetInitFlowUrl(string? aal, string? refresh, string? returnTo, string? organization,
string? loginChallenge)
{
return api.GetUrlForBrowserFlow("login", new Dictionary<string, string?>
{
["aal"] = aal ?? "",
["refresh"] = refresh ?? "",
["return_to"] = returnTo ?? "",
["organization"] = organization ?? ""
["organization"] = organization ?? "",
["login_challenge"] = loginChallenge ?? ""
});
}

Expand Down

0 comments on commit cf1d298

Please sign in to comment.