W.I.P [add] feature host_iso #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josenk
reviewed
Oct 19, 2020
There was a problem hiding this comment.
If you would like to make this complete.
- You need to edit guest-read.go (to read the current settings)
- Edit guest-import.go (To import).
- Validate that an "apply" will fix "broken" cdrom settings. (ie, go to the console, change the cdrom settings, then make sure a "terraform apply" will fix the cdrom to your settings.)
josenk
reviewed
Oct 19, 2020
esxi/guest-create.go
Outdated
| vmx_contents = vmx_contents + | ||
| fmt.Sprintf("ide1.present = \\\"TRUE\\\"\n") + |
josenk
reviewed
Oct 19, 2020
README.md
Outdated
| @@ -202,6 +202,7 @@ Configuration reference | |||
| * clone_from_vm - Source vm to clone. Mutually exclusive with ovf_source option. | |||
| * ovf_source - ovf files or URLs to use as a source. Mutually exclusive with clone_from_vm option. | |||
| * disk_store - Required - esxi Disk Store where guest vm will be created. | |||
| * host_iso - Optional - Attaching an iso file on the ESXi host. - e.g. "datastore1/iso/centos.iso" | |||
There was a problem hiding this comment.
Could you rename this resource to "cdrom_datastore_iso". It will match (closer) the web gui description so it will be a bit more clear.
josenk
reviewed
Oct 19, 2020
esxi/guest-create.go
Outdated
| @@ -17,7 +18,7 @@ import ( | |||
|
|
|||
| func guestCREATE(c *Config, guest_name string, disk_store string, | |||
| src_path string, resource_pool_name string, strmemsize string, strnumvcpus string, strvirthwver string, guestos string, | |||
| boot_disk_type string, boot_disk_size string, virtual_networks [10][3]string, | |||
| boot_disk_type string, boot_disk_size string, virtual_networks [10][3]string, host_iso string, | |||
There was a problem hiding this comment.
Also rename the variable to match the resource name. (cdrom_datastore_iso)
josenk
reviewed
Oct 19, 2020
esxi/resource_guest.go
Outdated
| Optional: true, | ||
| ForceNew: false, | ||
| Default: nil, | ||
| Description: "Path on exsi host of iso file(e.g. datastore1/iso/centos.iso).", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the attachment of an iso file on the ESXi host.