Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApiView: port smaller set of feedback changes #47

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

trrwilson
Copy link
Collaborator

A few of the changes in #42 were contentious and we'd like to extract some of the more straightforward updates for the March release target.

This pulls in several of the aforementioned PR's changes:

  • OpenAIClientOptions now appropriate derives from PipelineClientOptions
  • GetLegacyCompletionClient is removed from OpenAIClient
  • Name properties have been clarified in non-trivial cases:
    • Several Name properties pertaining to functions are renamed to FunctionName
    • Message-specific participant Name properties are renamed to ParticipantName
  • Public setters on request models are removed, replaced where appropriate with init
  • Response model collection types are now initialized to empty where they were previously null
  • ChatMessageContent type conversions to string and (new) Uri are explicit instead of implicit
  • CreatedAt is now present on GeneratedImageCollection (in addition to its existing copy-placement in constituent GeneratedImage instances)
  • (new) Assistants override properties are renamed to e.g. InstructionsOverride to avoid misleading apparent verb symbols like OverrideInstructions

Incidentals:

  • Many files have accumulated using statements cleaned up
  • batch and batch_output are added to OpenAIFilePurpose
  • pcm is added to transcription/translation formats

Intentionally deferred:

  • Introduction of nullable reference types (contentious, complex)
  • Comprehensive serialization update w/helper (complex)
  • Rename of content to text on ChatRequestAssistantMessage (contentious)

@trrwilson trrwilson changed the title port smaller set of feedback changes ApiView: port smaller set of feedback changes Mar 28, 2024
@trrwilson trrwilson merged commit e81f3dd into main Mar 29, 2024
1 check passed
@trrwilson trrwilson deleted the user/travisw/feedback-changes-subset branch May 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants