ApiView: port smaller set of feedback changes #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the changes in #42 were contentious and we'd like to extract some of the more straightforward updates for the March release target.
This pulls in several of the aforementioned PR's changes:
OpenAIClientOptions
now appropriate derives fromPipelineClientOptions
GetLegacyCompletionClient
is removed fromOpenAIClient
Name
properties have been clarified in non-trivial cases:Name
properties pertaining to functions are renamed toFunctionName
Name
properties are renamed toParticipantName
init
ChatMessageContent
type conversions to string and (new) Uri are explicit instead of implicitCreatedAt
is now present onGeneratedImageCollection
(in addition to its existing copy-placement in constituentGeneratedImage
instances)InstructionsOverride
to avoid misleading apparent verb symbols likeOverrideInstructions
Incidentals:
using
statements cleaned upbatch
andbatch_output
are added toOpenAIFilePurpose
pcm
is added to transcription/translation formatsIntentionally deferred:
content
totext
onChatRequestAssistantMessage
(contentious)