New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove canvas.shim circular dependency #753

Merged

jonobr1 merged 2 commits into dev from 750-circular-dep

Jan 1, 2025

Owner

jonobr1 commented Jan 1, 2025

Addresses:

[Bug] Circular dependencies have been introduced #750

Correctly encapsulates modules to be order of least resistance by:

Removes CanvasRenderer.Utils.shim method
Renames canvas-shim to canvas-polyfill for headless use
Imports only CanvasPolyfill, not the full renderer in Two.Texture

jonobr1 added 2 commits

December 31, 2024 17:11


          WIP: Circular Dependency

cc6acf7


          Removed circular dependency

jonobr1 merged commit 1e2b8c1 into dev

1 check passed

jonobr1 deleted the 750-circular-dep branch

January 1, 2025 01:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet